refactor(test): check freemem without module #2231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors a test to eliminate the Sys::Statistics::Linux dependency by using the Virtual Manager's built-in free_memory method instead. This simplifies the codebase by removing an external dependency that was only used in this single test file.
Key Changes:
- Replaced
Sys::Statistics::Linuxwith VM's nativefree_memory()method - Simplified domain creation logic by removing redundant error handling
- Updated
_check_free_memory()to accept a VM parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| t/55_freemem.t | Refactored to use VM's free_memory() method and removed Sys::Statistics::Linux dependency; simplified test logic |
| Makefile.PL | Removed Sys::Statistics::Linux from dependencies list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can get free memory from the Virtual Manager and get rid of this dependency used only for this test.