[4주차/유징] 워크북 제출합니다. #47
Open
+5,681
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wupe1001
reviewed
Oct 10, 2025
Comment on lines
+283
to
+293
| {step === 1 && <EmailStep onNext={handleEmailNext} />} | ||
| {step === 2 && ( | ||
| <PasswordStep onNext={handlePasswordNext} onPrev={() => setStep(1)} /> | ||
| )} | ||
| {step === 3 && ( | ||
| <NicknameStep | ||
| onSubmit={handleNameSubmit} | ||
| onPrev={() => setStep(2)} | ||
| email={collected.email!} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
저는 이 페이지를 구현할 때 컴포넌트를 분리하지 못해서 코드의 가독성이 좀 떨어졌었는데 이런 식으로 깔끔하게 구현할 수 있었네요. 꼭 다른 폴더로 분리하지 않아도 하나의 페이지 안에서 해결할 수 있는 좋은 방식이네요 !
sunnyinha
reviewed
Oct 10, 2025
| controllerRef.current?.abort(); | ||
| controllerRef.current = new AbortController(); | ||
|
|
||
| try { |
There was a problem hiding this comment.
controllerRef를 통해 기존 요청을 중단하고 새 요청으로 교체하는 구조가 아주 좋습니다.
다만 에러 발생 후 재요청 시 이전 에러 상태가 유지되지 않도록, setIsError(false)를 통해 에러 상태를 수동으로 초기화하는 것을 추천합니다
sunnyinha
reviewed
Oct 10, 2025
| @@ -0,0 +1,34 @@ | |||
| import { ChangeEvent, useEffect, useState } from "react"; | |||
|
|
|||
| interface UseFormProps<T> { | |||
There was a problem hiding this comment.
제너릭(T)을 활용해 useForm 훅이 다양한 폼 구조에 재사용될 수 있도록 설계한 부분이 정말 좋습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트
📌 주안점