[9,10주차/밤하늘] 워크북 제출합니다. #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m020202
reviewed
Jun 3, 2025
Comment on lines
+72
to
+73
| List<MissionResponseDTO.MissionDTO> userMissionDTOList = userMissionList.stream() | ||
| .map(MissionConverter::toMissionDTO).collect(Collectors.toList()); |
There was a problem hiding this comment.
이거 리스트로 안 받고, Page로 받으면 밑에서 따로 Page 관련 값들 세팅 안 해도 돼서 더 효율적일 것 같아요 !
Page<MissionResponseDTO.MissionDTO> userMissionDTOPage = userMissionList.map(MissionConverter::toMissionDTO);
Comment on lines
+46
to
+55
| Mission mission = missionRepository.findById(missionId).orElseThrow( | ||
| () -> new GeneralException(ErrorStatus.MISSION_NOT_FOUND) | ||
| ); | ||
|
|
||
| User user = userRepository.findById(userId).orElseThrow( | ||
| () -> new GeneralException(ErrorStatus.USER_NOT_FOUND) | ||
| ); | ||
|
|
||
| UserMission userMission = userMissionRepository.findByUserAndMission(user, mission).orElseThrow( | ||
| () -> new GeneralException(ErrorStatus.USERMISSION_NOT_FOUND) |
There was a problem hiding this comment.
엔티티 대신 storeId, memberId로 조회하는 게 더 효율적일 것 같아요 !
findByUserIdAndMissionid(userId, missionId)
| () -> new GeneralException(ErrorStatus.RESTAURANT_NOT_FOUND) | ||
| ); | ||
|
|
||
| Page<Mission> missionPage = missionRepository.findAllByRestaurant(restaurant, PageRequest.of(page, 10)); |
There was a problem hiding this comment.
페이징 기본 크기가 10이긴 한데, 프론트에서 혹시 다른 값을 요청할 수도 있으니 size 값도 받는 게 좋을 것 같아요 !
m020202
previously approved these changes
Jun 3, 2025
|
밤하늘 고생하셨습니다 ! |
m020202
approved these changes
Jun 24, 2025
|
밤하늘 고생하셨습니다 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 실습 체크리스트
✅ 컨벤션 체크리스트
📌 주안점