feat: add lastUpdated timestamp to all OO subgraphs, so we can use this when querying #99
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is when querying Signed-off-by: Matt Rice <[email protected]>
md0x
approved these changes
Aug 11, 2025
Contributor
md0x
left a comment
md0x
left a comment
There was a problem hiding this comment.
Looks good. Just a minor comment.
gsteenkamp89
approved these changes
Aug 11, 2025
Contributor
gsteenkamp89
left a comment
gsteenkamp89
left a comment
There was a problem hiding this comment.
One nit, but looks good!
|
|
||
| eventBased: Boolean | ||
|
|
||
| lastUpdated: BigInt |
Contributor
There was a problem hiding this comment.
We could make these non-nullible, if we intialize with BIGINT_ZERO like we do in getOrCreateOptimisticPriceRequest
Suggested change
| lastUpdated: BigInt | |
| lastUpdated: BigInt! |
md0x
reviewed
Aug 12, 2025
| request.currency = Bytes.fromI32(0); | ||
| request.reward = BIGINT_ZERO; | ||
| request.finalFee = BIGINT_ZERO; | ||
| request.lastUpdated = BIGINT_ZERO; |
Contributor
There was a problem hiding this comment.
Should we init the rest of the packages to Big_int zero for consistency? Or can we drop it since lastUpdate gets set on every PriceRequested event?
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.