fix(AnalyticalTable): improve scaleWidthMode "Grow" and "Smart"
#7752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +648 B (+0.14%) Total Size: 448 kB
ℹ️ View Unchanged
|
Pull Request Test Coverage Report for Build 17643841959Details
💛 - Coveralls |
Without the calculation, horizontal virtualization might not work as expected
Pull Request Test Coverage Report for Build 18341189305Details
💛 - Coveralls |
Na1k
reviewed
Oct 2, 2025
Comment on lines
472
to
478
| if (scaleWidthMode === AnalyticalTableScaleWidthMode.Smart) { | ||
| return calculateSmartColumns(columns, instance, hiddenColumns); | ||
| return calculateSmartAndGrowColumns(columns, instance, hiddenColumns); | ||
| } | ||
|
|
||
| if (scaleWidthMode === AnalyticalTableScaleWidthMode.Grow) { | ||
| return calculateSmartAndGrowColumns(columns, instance, hiddenColumns, true); | ||
| } |
There was a problem hiding this comment.
Following suggestion:
if (scaleWidthMode === AnalyticalTableScaleWidthMode.Smart) {
const calculatedColumns = calculateSmartAndGrowColumns(visibleColumns, instance, hiddenColumns)
// Map calculated widths back to all columns (including hidden ones)
return columns.map((column) => {
const isHidden = hiddenColumns.includes(column.id ?? column.accessor)
if (isHidden) {
// Return hidden columns unchanged
return column
}
// Find the calculated column
const calculatedColumn = calculatedColumns.find(
(col) => (col.id ?? col.accessor) === (column.id ?? column.accessor)
)
return calculatedColumn || column
})
}
if (scaleWidthMode === AnalyticalTableScaleWidthMode.Grow) {
const calculatedColumns = calculateSmartAndGrowColumns(visibleColumns, instance, hiddenColumns, true)
// Map calculated widths back to all columns (including hidden ones)
return columns.map((column) => {
const isHidden = hiddenColumns.includes(column.id ?? column.accessor)
if (isHidden) {
// Return hidden columns unchanged
return column
}
// Find the calculated column
const calculatedColumn = calculatedColumns.find(
(col) => (col.id ?? col.accessor) === (column.id ?? column.accessor)
)
return calculatedColumn || column
})
}Explanation: When using the suggested fix in my app, I get flickering hidden columns + hidden columns are shown upon expanding a subrow (tree table).
My best guess would be that when you return fewer columns than you received, react-table thinks columns have been added/removed, triggering a recalculation with different visibleColumns.length and resetting hidden columns.
|
Hi @Na1k, Thanks for the suggestion! I’ll take a look as soon as possible. Currently I’m busy preparing the next minor release, but we’ll put this fix on hold for now until I had the time to check your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7790