Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Conversation

jandusek
Copy link

In order for the Video Quickstart JS to be able to process the token, it needs to be returned as a JSON.

@ceaglest
Copy link

ceaglest commented Mar 27, 2018

As far as I know all of the token servers return the same format - a raw text body. Please don't merge a change unless its coordinated with the other dependencies of this project:

https://github.com/twilio/video-quickstart-swift
https://github.com/twilio/video-quickstart-objc
https://github.com/twilio/video-quickstart-android

As well as all of the other example servers.

@jandusek
Copy link
Author

The Node.js quickstart's /token returns JSON:
https://github.com/twilio/video-quickstart-js/blob/master/server/index.js#L73-L76

And the JS client expects JSON:
https://github.com/twilio/video-quickstart-js/blob/master/quickstart/src/index.js#L43

Good point about the other dependencies, I'm not sure what format those need.

But this should probably be unified one way or the other.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants