Allow bind ports to be customized in .env #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the Caddy bind ports to be customized with .env variables. This allows more versatile deployments behind reverse proxies without needing changes that will cause conflict when upgrading.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the Caddy bind ports to be customized with .env variables. This allows more versatile deployments behind reverse proxies without needing changes that will cause conflict when upgrading.
When hosting Ghost containers behind a reverse proxy, or an a machine where ports 80/443 are already in use, we need to edit
compose.ymlwith different ports. This change simplifies that by allowing thost changes to be made in.env. This also makes updates easier, as we don't need to worry about conflicts incompose.yml.I'm happy to consider other approaches; putting this here as a starting point.