Skip to content

Remove Complete message type per updated TAIP specifications #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pelle
Copy link
Contributor

@pelle pelle commented Jun 26, 2025

Summary

  • Removes the Complete message type from the codebase following the updated TAIP specifications
  • Updates all related code, tests, and documentation
  • Aligns with commit 6baaa04f459d4641500d507d2c6afcddbeaf157f in the TAIPs repository

Changes Made

Code Changes

  • Removed Complete message implementation:

    • Deleted tap-msg/src/message/complete.rs
    • Removed Complete export from tap-msg/src/message/mod.rs
  • Updated MCP tools:

    • Removed CompleteTool from tap-mcp/src/tools/transaction_tools.rs
    • Removed CompleteTool registration from tap-mcp/src/tools/mod.rs
    • Removed complete_schema from tap-mcp/src/tools/schema.rs
  • Updated tests:

    • Updated tap-agent/tests/test_vectors_validation.rs to remove Complete handling
    • Updated MCP integration test to expect 30 tools instead of 31
    • Removed Complete test vectors directory

Documentation Changes

  • Updated README.md to list "Cancel, Revert" instead of "Complete" in supported message types

Test Plan

  • All tests pass (cargo test --workspace)
  • Code builds successfully (cargo build)
  • No remaining references to Complete message type in code
  • Documentation has been updated

Context

The Complete message was removed from TAIP-14 in favor of using the standard TAIP-4 authorization flow (Payment -> Authorize -> Settle). This simplifies the protocol by removing redundant message types.

🤖 Generated with Claude Code

- Remove Complete message implementation from tap-msg
- Remove CompleteTool from tap-mcp tools
- Update test files to remove Complete references
- Update MCP integration test to expect 30 tools instead of 31
- Update README.md to list Cancel and Revert instead of Complete

This aligns the codebase with the updated TAIP specifications where
the Complete message has been removed in favor of using the standard
TAIP-4 authorization flow (Payment -> Authorize -> Settle).

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant