feat: adapt to newer changes of v0 #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For your information: This branch is already tested. |
Closed
velddev
reviewed
Sep 13, 2025
topgg.rc
Outdated
Comment on lines
20
to
21
| VALUE "FileVersion", "3.0.0" | ||
| VALUE "ProductVersion", "3.0.0" |
There was a problem hiding this comment.
Why is this a major version? did the library break for devs?
There was a problem hiding this comment.
Some changes here are breaking, like:
- Fetching bot stats now only returns the server count as shards are deprecated.
- The ability to fetch Top.gg users (
get_user) is removed. - The minimum supported version for building the library is increased from
3.8.2to3.15.
There was a problem hiding this comment.
Most breaking changes reverted, with the exception of the CMake version (tried using an older version, posting stats did not work.)
The latest version is now 2.1.0 instead of 3.0.0.
velddev
reviewed
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull request is a toned down version of #12. This pull request focuses solely on the
changes done to the SDK in the v0 of the API. Such as:
LICENSE.Other changes will be issued in subsequent pull requests once this pull request is merged.