Support creating s3 pipeline with KMS key config #35
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvika-tonic
reviewed
Apr 18, 2025
| @@ -105,7 +106,8 @@ def create_s3_pipeline( | |||
| Whether to generate a redacted version of the file in addition to the parsed output. Default value is `False`. | |||
| aws_credentials_source: Optional[str] | |||
| For an Amazon S3 pipeline, how to obtain the AWS credentials. Options are `user_provided` and `from_environment`. For `user_provided`, you provide the credentials in the `credentials` parameter. For `from_environment`, the credentials are read from your Textual instance. | |||
|
|
|||
| kms_key_arn: Optional[str] | |||
| When provided, the KMS key denoted by the ARN will be used to encrypted files prior to writing to output location via SSE-KMS. This value cannot be changed later. | |||
There was a problem hiding this comment.
Suggested change
| When provided, the KMS key denoted by the ARN will be used to encrypted files prior to writing to output location via SSE-KMS. This value cannot be changed later. | |
| When provided, the KMS key denoted by the ARN will be used by AWS to encrypt files prior to writing to output location via SSE-KMS. This value cannot be changed later. |
zvika-tonic
reviewed
Apr 18, 2025
There was a problem hiding this comment.
@akamor I never set this up and ran it, so haven't tested your change myself.
A few questions:
- Is this repo the only Textual SDK we have? I remember seeing something in Solar, but assuming it was consolidated to this repo.
- Is the purpose here to expose the configuration and documentation for the KMS ability, as well as test that creating a pipeline with this setting does not cause any failure? (you're not testing the actual encryption setting on S3, neither you should at this context)
- Do you want me to set it up for testing? Maybe next week when we're all in person that would be easy to troubleshoot if something doesn't work with the Python dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.