Skip to content

Make stream creation atomic #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 21 commits into
base: dev
Choose a base branch
from
Draft

Make stream creation atomic #43

wants to merge 21 commits into from

Conversation

@TomAFrench
Copy link
Owner

@TomAFrench TomAFrench commented Apr 9, 2020 •
edited
Loading

This PR consolidates the two transactions to create a stream (sending ZkAsset to contract and initialising stream) into one.

Currently blocked as the AZTEC SDK doesn't support signing an approval for the contract to submit the JoinSplit proof. The approval could be generated outside the sdk could be a worrying change to the standard flow for users.

closes #25

Tasks before merging:

  • test failure conditions in StreamUtilities.sol
  • test success outcomes of StreamUtilities.sol functions
  • update frontend to call new sdk method to get signed proof
  • deploy new contract to rinkeby to close deploy new contract to production #41

@vercel
Copy link

vercel bot commented Apr 9, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@vercel vercel bot temporarily deployed to Preview July 23, 2020 16:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make stream creation and sending of ZkAsset atomic

2 participants

@TomAFrench