Fix Command12 and Command16. #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yangfl
commented
Nov 23, 2024
•
yangfl
commented
- Remove wrong reserved fields in Command12.
- Handle EXTEND bit in Command16.
There are no requirements for lba_* to be unsigned values in 04-262r8.pdf, section 13.2.2. Besides, SMART LBA 0xC24F00 works pretty well with ATA PASS-THROUGH (12) command. Also add getter/setter for lba.
EXTEND bit is required to be set in order for LBA high parts to be considered. Set it within lba setter. Also remove the need for protocol field shifting for better code.
|
Hey! Thanks for the contribution and sorry for taking so long to get back to you. Unfortunately the changes as-is seem to break under Linux, specifically your 2nd commit, 76fe427. I need to take a closer look before we can look at merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.