command to zero elevator and move to elevator setpoints #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
bro what is this pr for |
Ishan1522
changed the title
Member
I updated the name |
Member
|
why do we have this PR and #99 ? |
Member
|
Idk bro he just made two PRs which branched off each other |
Ishan1522
requested changes
Feb 20, 2025
| // Elevator setpoints | ||
| public static final double LEVEL_1 = 59; | ||
| public static final double LEVEL_2 = 118; | ||
| public static final double LEVEL_3 = 177; |
| import frc.robot.subsystems.elevator.ElevatorSubsystem; | ||
|
|
||
| /* You should consider using the more terse Command factories API instead https://docs.wpilib.org/en/stable/docs/software/commandbased/organizing-command-based.html#defining-commands */ | ||
| public class ZeroElevator extends Command { |
Member
There was a problem hiding this comment.
If u r doing this in ur elevator safety pr u dont need it here.
Ishan1522
added a commit
that referenced
this pull request
Feb 25, 2025
* ll4 * huh * typo * devbot 🙏 * huh * possible elevator stator current limit * lol * idk * Initial commit * Got testing working!! * Cleaned up first test case * Did Mr GPT cook with making the workflow? * Making it so it only runs one action for tests * ig i fixed something?? * wrote test for getMegaTag1PoseEstimate * Updated code to use TigerHelpers * Updating TigerHelpers * More clean up and such, also its making me use Junit 4 for some reason * lock tf in * intake setpoint * Added more tests, comments, and did cleanup * intake * more clean up * blah blah * command to zero elevator and move to elevator setpoints (#96) * saaasafasas * format /fromat/forafs --------- Co-authored-by: Ishan <[email protected]> * sync * formawt * jflkjflkdsa * Lots of decent changes and big TigerHelpers changes * Got current unit tests passing * fuuuuuuuuuuuuuuuuuuuuuuck me * delete duplicate methods because jack is a dummy * kind of limelight * working repulsor? (#95) * repulsor * interesting * thingy * it kind of works? * do the mt2 thing * blublub * ??? * wat * nuke shit * whatity fuckity * what da freakity weakity * huh? * add reeflocations * huh * lmao i forgot super.execute again :( * huh * wat * jk * bruh * bruhther * idk * working repulsor * idk * push * Command factories on algae pivot, intake, and elevator (#94) * Command factories * enjw * huh * Formatting fixes * Did comments on pull request * jfew * Pulled from ishans thing * hkh * Formatting fixes * yipppie --------- Co-authored-by: Ishan1522 <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fuck all this * leds * climb pivot + algae flywheel (#35) * idk what i did * ermm * both coral and climb idk how to change branch name purely made by chatgpt plz review it :( * how u spell algae * added dealgaefier flywheel subsystem * i may have just fucked up everything * huuuuuuuuuuuuuh * dont look uhh * yippie?? * what did i dooooo * help omg * what * yuftdy * dasdfkadsjfjlk * ghfvh * flywheel done * helpppp review the pr so i know what to do pleaseee Co-authored-by: junocapra <[email protected]> * i dont think i actually wrote any of this from my own brain * Formatting fixes * what am i doinggg * almost done????? * push * I THINK ITS DONE GUYS :OO jkjk look over pr plz --------- Co-authored-by: Ishan1522 <[email protected]> Co-authored-by: aridavidson001 <[email protected]> Co-authored-by: junocapra <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * format * rename :) * Funnel subsystem max chen (#79) * ezpz easy fix top team * did elevator * Ezpz * I hate position * Time to test sim * Removed comments * push * so * faoisjoisajoifsafsa * khkjkjkj * sneaky lil paste * Format ./format ./gradlew spotlessApply * Find and replace (shhh)+encoder+ezpz gearratio * So like whoops forgor * funnel things * resolve errors --------- Co-authored-by: urbanmass <[email protected]> Co-authored-by: Ishan1522 <[email protected]> Co-authored-by: Max Luna <[email protected]> * huh * huh * changes * Add Vision tests and switch to TigerHelpers (#102) * delete comments * delete comments * pr changes * do da mergey wergey --------- Co-authored-by: jgelia <[email protected]> Co-authored-by: mychenezpz <[email protected]> Co-authored-by: junocapra <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Abigail-27 <[email protected]> Co-authored-by: aridavidson001 <[email protected]> Co-authored-by: junocapra <[email protected]> Co-authored-by: urbanmass <[email protected]> Co-authored-by: Max Luna <[email protected]> Co-authored-by: Jack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok