Skip to content

Adbc raii #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Adbc raii #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aa1f4c
functional RAII version of the ingestion_stream as a proof of concept
Tishj Jun 7, 2023
7134aef
Merge remote-tracking branch 'upstream/master' into adbc_raii
Tishj Aug 1, 2023
0754362
Merge branch 'adbc_missing_methods' into adbc_RAII
Tishj Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/config/uncovered_files.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ main/appender.cpp 23
main/attached_database.cpp 14
main/chunk_scan_state.cpp 21
main/capi/appender-c.cpp 3
main/capi/arrow-c.cpp 5
main/capi/arrow-c.cpp 8
main/capi/cast/from_decimal-c.cpp 5
main/capi/cast/utils-c.cpp 3
main/chunk_scan_state/query_result.cpp 28
Expand Down
1 change: 1 addition & 0 deletions src/common/adbc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
add_library_unity(duckdb_adbc OBJECT adbc.cpp driver_manager.cpp)
add_subdirectory(nanoarrow)
set(ALL_OBJECT_FILES
${ALL_OBJECT_FILES} $<TARGET_OBJECTS:duckdb_adbc>
PARENT_SCOPE)
Loading