Skip to content

Conversation

Tishj
Copy link
Owner

@Tishj Tishj commented Jul 4, 2024

This should remove all need for the:

if (!connection) {
    throw ConnectionException("Connection has already been closed");
}

Which is repeated in many functions and easily overlooked in others, resulting in InternalExceptions instead before.
Now those InternalExceptions have been downgraded to ConnectionException in this area.

Tishj added 2 commits July 4, 2024 22:00
…of an InternalException when it's accessed and it's null
… ConnectionException when it's null (because it was closed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant