Support dimension labels in tiledb_query_get_field.
#4626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #39110: tiledb_query_get_field does not consider dimension labels.. |
|
Closing for now. We don't want to support dimension labels here for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-39110
Currently
tiledb_query_get_fieldsupports only query fields on attributes, dimensions and aggregates, causing it to fail if called with the name of a dimension label. This PR adds support for getting the query fields corresponding to dimension labels, and adds a new value in thetiledb_field_origin_tenumeration.Unblocks TileDB-Inc/TileDB-CSharp#258.
TYPE: BUG
DESC: Fix dimension labels not being recognized by
tiledb_query_get_field.TYPE: C_API
DESC: Add a new field origin
TILEDB_DIMENSION_LABEL_FIELD.