Typed base schema meta #17
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR introduces stronger TypeScript typings for the extension functions by parameterizing the schema metadata with a generic map of named types. It also adds a new "all" method to BaseSchemaMeta and updates the type signatures of schema wrapping helper functions.
Reviewed Changes
| File | Description |
|---|---|
| packages/extend/src/index.ts | Added generic type parameter for schema metadata, updated helper functions to use stricter typings, and introduced the "all" method for accessing schema types |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
| typeof extension === "function" | ||
| ? extension({ | ||
| schema, | ||
| all(name) { |
There was a problem hiding this comment.
The 'all' method lacks an else branch to handle the case where 'getType(name as string)' does not match any of the known GraphQL type checks. Consider adding an error throw for unsupported types.
| }, | ||
| object(name) { | ||
| const graphQLType = getType(name); | ||
| const graphQLType = getType(name as string); |
There was a problem hiding this comment.
[nitpick] The repeated explicit cast 'name as string' might indicate that the 'getType' function's type signature could be refined to accept a more specific type, thereby reducing the need for such casts.
Suggested change
| const graphQLType = getType(name as string); | |
| const graphQLType = getType(name); |
emmatown
force-pushed
the
typed-base-schema-meta
branch
from
6d919d5 to
f24d07d
Compare
emmatown
changed the base branch from
use-real-graphql-js-types
to
easier-context-binding
emmatown
force-pushed
the
typed-base-schema-meta
branch
from
f24d07d to
5f0c5e7
Compare
emmatown
force-pushed
the
easier-context-binding
branch
3 times, most recently
from
8c90521 to
646198e
Compare
emmatown
force-pushed
the
typed-base-schema-meta
branch
from
5f0c5e7 to
a174199
Compare
emmatown
force-pushed
the
easier-context-binding
branch
from
646198e to
beb4055
Compare
emmatown
force-pushed
the
typed-base-schema-meta
branch
2 times, most recently
from
e83658f to
b566ece
Compare
emmatown
force-pushed
the
easier-context-binding
branch
from
beb4055 to
af71214
Compare
emmatown
force-pushed
the
typed-base-schema-meta
branch
from
b566ece to
56375be
Compare
emmatown
force-pushed
the
easier-context-binding
branch
2 times, most recently
from
4acd1ff to
bc4b76a
Compare
emmatown
force-pushed
the
typed-base-schema-meta
branch
from
56375be to
83f17ec
Compare
emmatown
force-pushed
the
easier-context-binding
branch
from
bc4b76a to
a2c76c6
Compare
emmatown
force-pushed
the
typed-base-schema-meta
branch
from
83f17ec to
1fcf347
Compare
emmatown
force-pushed
the
easier-context-binding
branch
from
a2c76c6 to
75dcde4
Compare
emmatown
force-pushed
the
typed-base-schema-meta
branch
from
1fcf347 to
46d3bb5
Compare
emmatown
force-pushed
the
easier-context-binding
branch
from
75dcde4 to
b2c3899
Compare
emmatown
force-pushed
the
typed-base-schema-meta
branch
2 times, most recently
from
4d52d81 to
d5e6cb9
Compare
emmatown
force-pushed
the
easier-context-binding
branch
2 times, most recently
from
858fd76 to
6c9b7bf
Compare
emmatown
force-pushed
the
typed-base-schema-meta
branch
2 times, most recently
from
9e507e8 to
58b9bac
Compare
emmatown
force-pushed
the
easier-context-binding
branch
from
6c9b7bf to
c7fac30
Compare
emmatown
force-pushed
the
typed-base-schema-meta
branch
2 times, most recently
from
84cf8f4 to
4e204ba
Compare
emmatown
force-pushed
the
typed-base-schema-meta
branch
from
4e204ba to
51e9c60
Compare
emmatown
force-pushed
the
typed-base-schema-meta
branch
from
51e9c60 to
33ad3b5
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if I want to ship this.
Big open question around the
allmethod:Typestype" behaviour so that it only accepts known type names?all? Other ideas:strictanynamed