Skip to content

Arbitrary code execution vulnerability #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wimleers
Copy link
Contributor

                '#lazy_builder' => [
                    $request->get('callback'),
                    $request->get('args'),
                ]

means arbitrary code could be executed. For example $request->get('callback') === 'unlink' and $request->get('args') = ['~/.ssh/*'].

```
                '#lazy_builder' => [
                    $request->get('callback'),
                    $request->get('args'),
                ]
```

means arbitrary code could be executed. For example `$request->get('callback') === 'unlink'` and `$request->get('args') = ['~/.ssh/*']`.
@wimleers
Copy link
Contributor Author

Note that \Drupal\big_pipe\Render\Placeholder\BigPipeStrategy::generateBigPipePlaceholderId()'s result is purely informative; it's never used to determine which code to execute. Hence BigPipe does not suffer from the same security vulnerability.

@esolitos
Copy link

esolitos commented Nov 6, 2018

@ThijsFeryn Maybe you should add this disclaimer in the project readme, doesn't need to be fixed right now as this is a PoC module, but better alert any possible user!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants