Skip to content

Conversation

thekovic
Copy link

I added a toggle to enable/disable the on-screen dither effect which can be distracting in, for example, Indiana Jones and the Infernal Machine. I tested integration with a frontend in m64p and everything seems to work as expected. Probably consider this to be more of a draft. Currently implemented in a rather ugly, hacky way. Feedback very welcome.

image

@RokkumanX
Copy link

@thekovic

Are there any updates on this? Because this would definitely be a sought out feature to have officially.

@Themaister

Is there any specific reason not to have this feature anymore since I also have seen a video footage of the dithering being off.

Off-topic: I saw a comment from you thekovic in a video from Modern Vintage Gamer regarding Super Mario 64, I kinda smiled when I saw your name and knew that you are on GitHub :)

@RinMaru
Copy link

RinMaru commented Mar 9, 2023

Really hope this gets added Dithering just looks so bad and this alone would serve well on those with HD displays.

@thekovic thekovic changed the title Added toggle of screen dither effect Added option to force specific dither mode Mar 11, 2023
@thekovic
Copy link
Author

It was time to do at least something for this - I've changed it so that the user can select any of the 4 available dither modes on the N64 and made the code a bit nicer. The big picture solution for how to inject user option into a function that was not made with this in mind (by using a static variable) remains though. It's not "clean code" but it works and I think modern PCs can handle the extra if statement and a couple bytes of extra writes.

I've tested the implementation in ares so if they're interested in that for ares-emulator/ares#1012 , I'm all ears.

@user18081972
Copy link

Could you compile this into a .dll that can be used in Rosalie's Mupen GUI and share it with us that would be neat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants