Skip to content

Conversation

@2l47
Copy link
Contributor

@2l47 2l47 commented Apr 16, 2022

If this update could be pushed to the forum thread as well I'd appreciate it.

@FlashTVR
Copy link
Member

@2l47 Does this also fix the issue mentioned here?
https://forums.alliedmods.net/showpost.php?p=2779649&postcount=132

As an FYI, @stevotvr passed away last year and I am not super familiar with his code yet.

@2l47
Copy link
Contributor Author

2l47 commented May 31, 2022

My condolences.

384f46b does not fix that issue; I didn't notice it as I'd configured "demos" as the path already in my testing. I should have some time this weekend to look into a fix.

@2l47 2l47 mentioned this pull request Aug 10, 2022
@2l47
Copy link
Contributor Author

2l47 commented Aug 10, 2022

This should be fixed in 8b1883a

@2l47
Copy link
Contributor Author

2l47 commented Aug 26, 2022

Bumping because github is quirky

@2l47
Copy link
Contributor Author

2l47 commented Aug 26, 2022

Actually, I'm not sure if github has updated this PR with my branch's changes. Might want to just merge #4 instead if those changes are alright.

@FlashTVR FlashTVR merged commit 2e8131e into TheVilleOrg:master Dec 18, 2022
@2l47
Copy link
Contributor Author

2l47 commented Dec 22, 2022

@FlashTVR Yeah, GitHub only merged the first commit on this branch and not all three since it didn't track my pushes for this PR while my account was flagged. It's probably easier to just clone this and my fork and then force-push my fixup branch's history to master. Doing this won't have a nice little PR message but it'll fix the history cleanly enough, as if I had write access.

Haven't tested the following but something like it should work:

git clone https://github.com/TheVilleOrg/sourcemod sourcemod-fixup; pushd sourcemod-fixup
git branch -m old-master
git remote add syd_fork https://github.com/2l47/StevoTVR-sourcemod
git fetch
git checkout fixup
git branch -m master
git push origin master -f
popd; rm -r sourcemod-fixup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants