refactor: use slices.Equal to simplify code

[minxinyi]

Summary

In the Go 1.21 standard library, a new function has been introduced that enhances code conciseness and readability. It can be find here.

...

Changes

• ...
• ...

Testing

Steps

...

Results

Regressions

...

Notes for Reviewers

...

Checklist

• Scope: The referenced issue is addressed, there are no unrelated changes.
• Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
• Documentation: Relevant documentation is added or updated.
• Testing: The steps/process to test this feature are clearly explained including testing for regressions.
• Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
• Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
• Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

[nicholaspcr]

Thanks for your contribution, @minxinyi! You're right, using slices.Equal is a much better approach than the custom function.

I did a quick search and it looks like the old EqualChMasks function is still being used in a few other places in the band package. Would you be willing to update those as well? That would make this contribution even more complete. If you do a search for EqualChMasks in the codebase, you should be able to find the other locations easily.

Once those are updated, I'd be happy to approve and merge this PR.

[minxinyi]

Thanks for your contribution, @minxinyi! You're right, using slices.Equal is a much better approach than the custom function.

I did a quick search and it looks like the old EqualChMasks function is still being used in a few other places in the band package. Would you be willing to update those as well? That would make this contribution even more complete. If you do a search for EqualChMasks in the codebase, you should be able to find the other locations easily.

Once those are updated, I'd be happy to approve and merge this PR.

Thanks for your reply.

Modified. Please review it when you have time.

[nicholaspcr]

Hi @minxinyi. I investigated the CI failure and it was caused by a pre-existing issue in v3.35 that is now resolved. Please rebase your branch against the latest v3.35 to bring in the fix. Thanks for your contribution