Skip to content

MCCI PR3 #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

dhineshkumarmcci
Copy link

@dhineshkumarmcci dhineshkumarmcci commented Mar 31, 2025

Summary

...

Changes

  • new boards to vendor MCCI
  • updating decoders and their YAML file
  • adding partnering vendor Pallidus to repo

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dhineshkumarmcci
❌ Pranau-R
You have signed the CLA already but the status is still pending? Let us recheck it.

@Jaime-Trinidad
Copy link
Contributor

Hi @dhineshkumarmcci on the firmware and hardware versions, please do not delete the once that were already in the files, add the new ones below, fix this and I can review again this PR. Thank you

@Pranau-R
Copy link

Pranau-R commented Apr 30, 2025

Hi @Jaime-Trinidad, we have done the firmware and hardware version as you suggested and pushed the changes. Please review the pull request once again and let us know. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants