Skip to content

Fix wildcard without image #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix wildcard without image #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff06c1
Hide image header of article without image
Windows87 Feb 18, 2023
9ce88ed
Checks if the article has an image
Windows87 Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/Wildcard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const Header = (props) => (
<Text style={styles.header} category="h6">{props.title}</Text>
{props.verbose && (<Text category="p2" style={styles.date}>{formatDate(new Date(props.date))}</Text>)}
</View>
<Image source={{ uri: `${props.uri}?w=${width*pixelRatio}` }} style={{ flex: 1, height: 192 }} />
{ props.uri ? <Image source={{ uri: `${props.uri}?w=${width*pixelRatio}` }} style={{ flex: 1, height: 192 }} /> : null }
</React.Fragment>
)

Expand Down
13 changes: 9 additions & 4 deletions screens/Post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ if (Platform.OS === "android" && UIManager.setLayoutAnimationEnabledExperimental

export default function Post({ route, navigation }) {
const { article, sourceName } = route.params
const articleImage = article["jetpack_featured_media_url"]
const featuredMedia = `${article["jetpack_featured_media_url"]}?w=${pixelRatio*width}`
const colorScheme = useColorScheme()
const theme = useTheme()
Expand Down Expand Up @@ -98,18 +99,22 @@ export default function Post({ route, navigation }) {
// That would vastly increase loading time when so many posts are being fetched at once,
// most of which are not going to be tapped on anyway.

Model.media().id(article["featured_media"]).get().then(media => {
setCaption(decode(media.caption?.rendered).slice(3, -5))
if(article["featuredMedia"]) {
Model.media().id(article["featured_media"]).get().then(media => {
setCaption(decode(media.caption?.rendered).slice(3, -5))
LayoutAnimation.configureNext(LayoutAnimation.Presets.easeInEaseOut)
})
} else {
LayoutAnimation.configureNext(LayoutAnimation.Presets.easeInEaseOut)
})
}
}, [article])


return (
<React.Fragment>
<StatusBar style={statusBarStyle} />
<ImageHeaderScrollView
headerImage={{ uri: featuredMedia }}
headerImage={articleImage ? { uri: featuredMedia } : ''}
renderForeground={Foreground}
maxOverlayOpacity={0.75}
minOverlayOpacity={0.6}
Expand Down