Skip to content

Add alert to turn on push notifications, update version numbers #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add alert to turn on push notifications, update version numbers #268

wants to merge 7 commits into from

Conversation

grace00
Copy link
Collaborator

@grace00 grace00 commented Jun 4, 2020

Reasons for making this change

  • The alert lets users know their notifications aren't turned on and directs them to the settings page
  • Version numbers incremented to reflect major changes (is 1.3.2 -> 1.4.0 appropriate?)

Related tickets

fixes #239

Screenshots

Simulator Screen Shot - iPhone 8 Plus - 2020-06-04 at 16 00 50

@grace00 grace00 requested a review from epicfaace June 4, 2020 20:01
@hs4man21 hs4man21 changed the base branch from master to main September 20, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfaace epicfaace Awaiting requested review from epicfaace

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix notification toggles
1 participant
@grace00