Skip to content

fix(calendar): 修复value存在时日历定位不准确问题 #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(calendar): 修复value存在时日历定位不准确问题 #2058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/calendar/calendar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import props from './props';
import { useTNodeJSX } from '../hooks/tnode';
import TCalendarTemplate from './template';
import { usePrefixClass } from '../hooks/useClass';
import type { CalendarTrigger } from './type';

const { prefix } = config;

Expand Down Expand Up @@ -34,21 +35,24 @@ export default defineComponent({
context.emit('update:visible', v);
};

const onPopupVisibleChange = (v: boolean) => {
if (!v) {
props.onClose?.('overlay');
} else {
nextTick(() => {
selectedValueIntoView();
});
}
const onPopupVisibleChange = (v: boolean, trigger: CalendarTrigger) => {
Copy link
Collaborator

@anlyyao anlyyao Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得问题出在 popup ， visible 从 false --> true 时，onVisibleChange 事件没有正确触发。 建议优化 popup ，确保 popup 组件会在 visible 状态变化时（无论是外部控制还是内部操作）都能按预期触发 onVisibleChange 回调

if (!v) props.onClose?.(trigger);
context.emit('update:visible', v);
};

onMounted(() => {
if (!props.usePopup) selectedValueIntoView();
});

watch(
() => props.visible,
(val) => {
if (val) {
nextTick(() => selectedValueIntoView());
}
},
);

watch(
() => props.value,
(val) => {
Expand Down
Loading