Remove hardcoded variables in mesh_sam + fix small README typos #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for your fantastic open-source contributions!
While testing P3-SAM, I noticed that during demo inference in both
auto_mask.pyandauto_mask_no_postprocess.py, the input parameterspoint_numandprompt_numpassed to themesh_samfunction are currently hardcoded and not affected by the provided values. This causes the inference process to run out of memory, even on high-end GPUs such as RTX 4090.Deleting these hardcoded values allows the proper function arguments to be used, which resolves the OOM issue. Also applied the same fix to XPart for consistency.
This PR also fixes a few minor typos in the READMEs.
Thanks