IOS - converting geo coords #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great but I can't merge it since your fork is behind. Can you update it perhaps and resubmit the PR? You can sync with the upstream (this repo) by executing these commands in the Terminal from within your fork's folder: |
…gGeoCoords # Conflicts: # demo/index.html # src/ios/CDVMapbox.h # src/ios/CDVMapbox.m
|
That was the occasion for my ever first conflict resolution and pull request. Good day :) Next step will be exposing the regionWillChange callback. |
|
Looks great! I've happily merged and tested your changed 👍 Regarding offline support and other extensions of this plugin: please check #22 and see if there's some way to cooperate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing:
convertPoint:toCoordinateFromView:convertCoordinate:toPointToView:Usage:
LatLng convertCoordinate(latLng: LatLng, callbackSuccess: function, callbackError: function)
Point convertPoint(point: Point, callbackSuccess: function, callbackError: function)
Returns an error if a point absolute value < 0 or if coords absolute value > 90 or 180.
Also added two button in the demo.html which convert center of the screen point<->coordinates.