-
-
Notifications
You must be signed in to change notification settings - Fork 387
feat: log filtering #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Xe
wants to merge
5
commits into
main
Choose a base branch
from
Xe/log-filters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+469
−132
Open
feat: log filtering #991
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
10f0593
feat(expressions): add CEL log filtering calls
Xe e0d2136
feat(config): add support for log filters
Xe 5351673
feat(lib/logging): add slog filter handler, move slog init logic here
Xe a7a5e0d
feat(lib): add log filtering rules
Xe 0510aad
docs: clarify that log filters remove lines if the filter matches
Xe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
package logging | ||
|
||
import ( | ||
"context" | ||
"log/slog" | ||
) | ||
|
||
// Filterer is the shape of any type that can perform log filtering. This takes | ||
// the context of the log filtering call and the log record to be filtered. | ||
type Filterer interface { | ||
Filter(ctx context.Context, r slog.Record) bool | ||
} | ||
|
||
// FilterFunc lets you make inline log filters with plain functions. | ||
type FilterFunc func(ctx context.Context, r *slog.Record) bool | ||
|
||
// Filter implements Filterer for FilterFunc. | ||
func (ff FilterFunc) Filter(ctx context.Context, r *slog.Record) bool { | ||
return ff(ctx, r) | ||
} | ||
|
||
// FilterHandler wraps a slog Handler with one or more filters, enabling administrators | ||
// to customize the logging subsystem of Anubis. | ||
type FilterHandler struct { | ||
next slog.Handler | ||
filters []Filterer | ||
} | ||
|
||
// NewFilterHandler creates a new filtering handler with the given base handler and filters. | ||
func NewFilterHandler(handler slog.Handler, filters ...Filterer) *FilterHandler { | ||
return &FilterHandler{ | ||
next: handler, | ||
filters: filters, | ||
} | ||
} | ||
|
||
// Enabled passes through to the upstream slog Handler. | ||
func (h *FilterHandler) Enabled(ctx context.Context, level slog.Level) bool { | ||
return h.next.Enabled(ctx, level) | ||
} | ||
|
||
// Handle implements slog.Handler and applies all filters before delegating to the base handler. | ||
func (h *FilterHandler) Handle(ctx context.Context, r slog.Record) error { | ||
// Apply all filters - if any filter returns false, skip the log | ||
for _, filter := range h.filters { | ||
if !filter.Filter(ctx, r) { | ||
return nil // Skip this log record | ||
} | ||
} | ||
return h.next.Handle(ctx, r) | ||
} | ||
|
||
// WithAttrs implements slog.Handler. | ||
func (h *FilterHandler) WithAttrs(attrs []slog.Attr) slog.Handler { | ||
return &FilterHandler{ | ||
next: h.next.WithAttrs(attrs), | ||
filters: h.filters, | ||
} | ||
} | ||
|
||
// WithGroup implements slog.Handler. | ||
func (h *FilterHandler) WithGroup(name string) slog.Handler { | ||
return &FilterHandler{ | ||
next: h.next.WithGroup(name), | ||
filters: h.filters, | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.