feat(lib): valkey backed store #622
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Xe Iaso <[email protected]>
Signed-off-by: Xe Iaso <[email protected]>
Xe
added a commit
that referenced
this pull request
Jul 1, 2025
I'm gonna be totally honest here, I'm still not sure why #564 is still an issue. This is really confusing and I'm going to totally throw out how Anubis issues challenges and redo it with Valkey (#201, #622). The problem seems to be that I assume that the makeChallenge function in package lib is idempotent for the same client. I have no idea why this would be inconsistent, but for some reason it is and I'm just at a loss for words as to why this is happening. This stops the bleeding by improving the UX as a stopgap. Signed-off-by: Xe Iaso <[email protected]>
Xe
added a commit
that referenced
this pull request
Jul 1, 2025
I'm gonna be totally honest here, I'm still not sure why #564 is still an issue. This is really confusing and I'm going to totally throw out how Anubis issues challenges and redo it with Valkey (#201, #622). The problem seems to be that I assume that the makeChallenge function in package lib is idempotent for the same client. I have no idea why this would be inconsistent, but for some reason it is and I'm just at a loss for words as to why this is happening. This stops the bleeding by improving the UX as a stopgap. Signed-off-by: Xe Iaso <[email protected]>
3 tasks
Xe
added a commit
that referenced
this pull request
Jul 1, 2025
I'm gonna be totally honest here, I'm still not sure why #564 is still an issue. This is really confusing and I'm going to totally throw out how Anubis issues challenges and redo it with Valkey (#201, #622). The problem seems to be that I assume that the makeChallenge function in package lib is idempotent for the same client. I have no idea why this would be inconsistent, but for some reason it is and I'm just at a loss for words as to why this is happening. This stops the bleeding by improving the UX as a stopgap. Signed-off-by: Xe Iaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables future fun with pass rate analysis.
Checklist:
[Unreleased]section of docs/docs/CHANGELOG.mdnpm run test:integration(unsupported on Windows, please use WSL)