feat(QTDI-693): manage nested jars #969

undx · 2024-12-17T17:25:58Z

https://qlik-dev.atlassian.net/browse/QTDI-693

component-runtime:

feat(QTDI-693): manage nested jars #969

master:

maintenance/8.0.2 :

container/container-core/src/main/java/org/talend/sdk/component/container/ContainerManager.java

...runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java

ozhelezniak-talend

left comments

Copilot

Pull Request Overview

This pull request implements support for managing nested JARs in the Talend SDK component runtime. The changes enable the system to detect and handle components that are packaged within fat JARs with embedded Maven repositories.

Adds nested repository detection logic to check for MAVEN-INF/repository resources when default repository paths are used
Extends classloader functionality to track and expose nested JAR URLs
Updates component scanning to handle nested repositories with proper filtering

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
ContainerManager.java	Implements nested repository detection and fallback logic for fat JAR scenarios
Container.java	Adds public accessor method for nested repository status
ConfigurableClassLoader.java	Tracks nested URLs and overrides getURLs() to include them
ComponentManagerTest.java	Updates test expectations to account for nested JAR handling
ComponentManager.java	Enhances component scanning to handle nested repositories with proper filtering

Comments suppressed due to low confidence (1)

component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java:1328

[nitpick] The log message format with manual bracket prefix is inconsistent with typical logging patterns. Consider using standard log formatting without manual prefixes.

                        log.info("[onCreate] Can't read nested scanning.properties: {}", e.getMessage());

Copilot · 2025-07-17T07:55:04Z

container/container-core/src/main/java/org/talend/sdk/component/container/ContainerManager.java

+        if (PathFactory.get(System.getProperty("user.home")).resolve(".m2/repository").equals(rootRepo)) {
+            final URL nested = classLoaderConfiguration.getParent().getResource("MAVEN-INF/repository");
+            if (nested != null) {
+                rootRepo = Paths.get(nested.getFile().replace("file:", ""));


Using simple string replacement for URL handling is unreliable and may fail with encoded URLs or different URL formats. Consider using URI.create(nested.toString()).getPath() or proper URL decoding instead.

Suggested change

rootRepo = Paths.get(nested.getFile().replace("file:", ""));

rootRepo = Paths.get(URI.create(nested.toString()).getPath());

Copilot · 2025-07-17T07:55:04Z

container/container-core/src/main/java/org/talend/sdk/component/container/ContainerManager.java

+                .orElseGet(() -> PathFactory.get(System.getProperty("user.home")).resolve(".m2/repository"));
+        // if we've defaulted to user home m2 (fallback), we want to check if we're in running in a fatjar
+        if (PathFactory.get(System.getProperty("user.home")).resolve(".m2/repository").equals(rootRepo)) {


Removed null fallback for System.getProperty("user.home") that was present in the original code. This could cause NullPointerException if the system property is not set.

Suggested change

.orElseGet(() -> PathFactory.get(System.getProperty("user.home")).resolve(".m2/repository"));

// if we've defaulted to user home m2 (fallback), we want to check if we're in running in a fatjar

if (PathFactory.get(System.getProperty("user.home")).resolve(".m2/repository").equals(rootRepo)) {

.orElseGet(() -> PathFactory.get(Optional.ofNullable(System.getProperty("user.home")).orElse("/tmp")).resolve(".m2/repository"));

// if we've defaulted to user home m2 (fallback), we want to check if we're in running in a fatjar

if (PathFactory.get(Optional.ofNullable(System.getProperty("user.home")).orElse("/tmp")).resolve(".m2/repository").equals(rootRepo)) {

Copilot · 2025-07-17T07:55:04Z

...ntainer-core/src/main/java/org/talend/sdk/component/classloader/ConfigurableClassLoader.java

@@ -111,6 +111,8 @@ public class ConfigurableClassLoader extends URLClassLoader {
    @Getter
    private final List<String> cacheableClasses;

+    private List<URL> nestedURLs = new ArrayList<>();


The field should be declared as final since it's initialized once and never reassigned. Consider making it final for better immutability.

Suggested change

private List<URL> nestedURLs = new ArrayList<>();

private final List<URL> nestedURLs = new ArrayList<>();

* add snapshot plugin oss repo * remove talend-icon * remove org.talend.ui:talend-icon:3.8.0 it's deprecated dependency, and its content is already inside the folder of documentation/src/main/antora/modules/ROOT/assets/images/icons/svg

* feat(QTDI-113): Support Java 17 compilation (#936) --------- Co-authored-by: Emmanuel GALLOIS <[email protected]> Co-authored-by: undx <[email protected]> Co-authored-by: Axel CATOIRE <[email protected]>

* it was removed in 2020 and looks like we've missed it, it was added in a lot of modules for Cloud, but I think by mistake it was removed from component-runtime-manager.

* nexus creds for deps report * use settings.xml for deps report

- fix springboot repackaging to BOOT-INF/ issue

sonar-eks · 2025-08-05T10:51:33Z

Quality Gate failed

67.90% Coverage on New Code (is less than 80.00%)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

undx and others added 8 commits December 17, 2024 11:34

feat(QTDI-693): expose nested repository member

13c0656

feat(QTDI-693): allow nested jar as root repository

b52c305

feat(QTDI-693): classes across many scanning.properties

c079f78

feat(QTDI-693): classes across many scanning.properties

b2386f1

feat(QTDI-693): include nested jars in getURLs

e34c77c

feat(QTDI-693): include nested jars in getURLs

fb44b73

feat(QTDI-693): fix test

409e850

Merge branch 'master' into undx/QTDI-693-runtime-fix

940ab2b

undx requested a review from ozhelezniak-talend January 9, 2025 15:01

ozhelezniak-talend reviewed Jan 10, 2025

View reviewed changes

container/container-core/src/main/java/org/talend/sdk/component/container/ContainerManager.java Show resolved Hide resolved

ozhelezniak-talend reviewed Jan 10, 2025

View reviewed changes

...runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java Show resolved Hide resolved

ozhelezniak-talend reviewed Jan 10, 2025

View reviewed changes

undx added 3 commits January 21, 2025 12:14

Merge branch 'master' into undx/QTDI-693-runtime-fix

5667ddb

feat(QTDI-675): pr comment

f2bad61

Merge branch 'master' into undx/QTDI-693-runtime-fix

a003c2a

ozhelezniak-talend previously approved these changes Feb 6, 2025

View reviewed changes

Merge branch 'master' into undx/QTDI-693-runtime-fix

1cfe2a6

ozhelezniak-talend requested a review from Copilot July 17, 2025 07:54

Copilot AI reviewed Jul 17, 2025

View reviewed changes

undx and others added 7 commits July 21, 2025 18:17

Merge branch 'master' into undx/QTDI-693-runtime-fix

29cdac2

Merge branch 'master' into undx/QTDI-693-runtime-fix

f712899

feat(QTDI-113): Support Java 17 compilation (#from:936) (#1061)

d6b1284

* feat(QTDI-113): Support Java 17 compilation (#936) --------- Co-authored-by: Emmanuel GALLOIS <[email protected]> Co-authored-by: undx <[email protected]> Co-authored-by: Axel CATOIRE <[email protected]>

fix(QTDI-1838): register ContainerFinder for studio (#1081)

be33a6a

* it was removed in 2020 and looks like we've missed it, it was added in a lot of modules for Cloud, but I think by mistake it was removed from component-runtime-manager.

chore(QTDI-1859): improve CI build (#1084)

8b9c01d

* nexus creds for deps report * use settings.xml for deps report

feat(QTDI-693): add plugins.properties location property

234cb50

- fix springboot repackaging to BOOT-INF/ issue

undx dismissed ozhelezniak-talend’s stale review via 234cb50 August 5, 2025 10:07

undx and others added 3 commits August 5, 2025 12:08

Merge branch 'master' into undx/QTDI-693-runtime-fix

bc8f215

feat(QTDI-693): fix path for plugins.properties location propert

ade85f7

feat(QTDI-693): fix property name

a4ec4b3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(QTDI-693): manage nested jars #969

feat(QTDI-693): manage nested jars #969

Uh oh!

undx commented Dec 17, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

ozhelezniak-talend left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

sonar-eks bot commented Aug 5, 2025

Uh oh!

Uh oh!

	rootRepo = Paths.get(nested.getFile().replace("file:", ""));
	rootRepo = Paths.get(URI.create(nested.toString()).getPath());

	private List<URL> nestedURLs = new ArrayList<>();
	private final List<URL> nestedURLs = new ArrayList<>();

feat(QTDI-693): manage nested jars #969

Are you sure you want to change the base?

feat(QTDI-693): manage nested jars #969

Uh oh!

Conversation

undx commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ozhelezniak-talend left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

sonar-eks bot commented Aug 5, 2025

Quality Gate failed

Uh oh!

Uh oh!

undx commented Dec 17, 2024 •

edited

Loading