chore/refactor: improvements for code base #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almeidx
reviewed
Aug 17, 2021
chrysomallos
changed the title
chrysomallos
force-pushed
the
chore/refactor
branch
2 times, most recently
from
70d006d to
3d75769
Compare
* Base32: use object assign and map * DeckEncoder: use reduce instead of push
chrysomallos
force-pushed
the
chore/refactor
branch
from
3d75769 to
141824d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to improve the code quality. I've fix some possible issues and make code more clean and safe against some issues. Fix some side effects in code when using reduce.
Changes:
I hope it's okay and useful to you.
removed: Fix issue by using split to generade character arrays if the string contains unicode values: f.e. Unicode-Issue by using the spread operator.