Return 404 for not-found routes #3801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ui-3801.dev.renku.ch |
ciyer
force-pushed
the
ciyer/missing-returns-404
branch
from
0b78c7d to
00d7b8c
Compare
ciyer
force-pushed
the
ciyer/missing-returns-404
branch
4 times, most recently
from
ee88044 to
e38af60
Compare
ciyer
force-pushed
the
ciyer/missing-returns-404
branch
from
e38af60 to
5ec5d10
Compare
ciyer
force-pushed
the
ciyer/missing-returns-404
branch
from
5ec5d10 to
681f981
Compare
leafty
reviewed
Aug 18, 2025
There was a problem hiding this comment.
Looks OK. We should take note of the following:
- https://renku-ci-ui-3801.dev.renku.ch/no-exists -> returns 404 and has no header and footer bars
- https://renku-ci-ui-3801.dev.renku.ch/help-no-exists -> returns 200 and has header and footer bars
Making this behave the proper way requires us to migrate to use the proper react-router routes (https://reactrouter.com/start/framework/routing), which we can do later and progressively.
Other minor comments below:
Co-authored-by: Flora Thiebaut <[email protected]>
leafty
approved these changes
Aug 20, 2025
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3798
/deploy