-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add design tokens and Container Section Card to Storybook #3744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andre-code
wants to merge
6
commits into
main
Choose a base branch
from
andrea/add-design-tokens-storybook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can access the deployment of this PR at https://renku-ci-ui-3744.dev.renku.ch |
41a846c
to
93aeed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces foundational updates to our Storybook:
✅ What's included
Design Tokens: New stories for the following tokens used across our UI:
Container Section Card: First documented component added under the new structure, following improved documentation practices for component stories in Storybook.
📚 Why this matters
We’ve started reorganizing our Storybook to align with the Atomic Design methodology, which the design team also follows. This structure will help improve consistency, reusability, and collaboration between design and development teams.
Our new Storybook structure looks like this:
📌 Next steps / To-dos for upcoming PRs
Data connector
card spacing (me-2
instead ofgap-2
).d-flex justify-content-between
instead ofms-auto
References
/deploy renku=release-2.5.0
! RESTORE THE PREVIOUS POINTER to
andrea/simplify-dc-form