chore: add multi-container sessions #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I really like this idea - I think we will need this sort of functionality sooner rather than later (see #11). We should complete and merge this RFC and work on defining the apps/dashboards use-case. Serving multiple containers could imply, for example, multiple Dockerfiles in a project, it can complicate CI, etc. |
rokroskar
reviewed
Sep 12, 2022
design/005-multi-container-sessions/005-multi-container-sessions.md
Outdated
Show resolved
Hide resolved
design/005-multi-container-sessions/005-multi-container-sessions.md
Outdated
Show resolved
Hide resolved
design/005-multi-container-sessions/005-multi-container-sessions.md
Outdated
Show resolved
Hide resolved
design/005-multi-container-sessions/005-multi-container-sessions.md
Outdated
Show resolved
Hide resolved
Member
Author
|
@rokroskar I am sorry for the delay. I will clean this up and request another review so that we can merge it. |
Member
Author
|
@rokroskar all done let me know what you think |
Member
Author
|
@rokroskar I added a question in the "Unresolved questions" section about mounting data in each container. |
rokroskar
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.