[WIP] Skypools v2

[meloket]

No description provided.

[syrohei]

• Missed update readme.md document for current development / getting started
• Missed test cases, use mainnet fork for test. like https://github.com/SwingbyProtocol/chainlink-integration
• Soliidity version should be 0.8.14 and lock it
• Missed function comments for linter
• abi&abigo generator should be need. follow this
  https://github.com/SwingbyProtocol/chainlink-integration

@meloket

[syrohei]

hey @meloket

• the interfaces should be implemented if an upgradable contract allows it.
  • https://github.com/SwingbyProtocol/skybridge-contract/blob/skypools-v2/contracts/SwapContractV1.sol#L7
• Soliidity version should be 0.8.14 and lock it
• Use mnemonic key for deployment instead of privatekey like this https://github.com/SwingbyProtocol/chainlink-integration/blob/master/hardhat.config.js#L35
  • https://github.com/SwingbyProtocol/skybridge-contract/blob/skypools-v2/hardhat.config.ts
• tests files need
• deployment scripts need (deploy, upgrade)
  • read this https://github.com/SwingbyProtocol/chainlink-integration/tree/master/script

[syrohei]

hey @meloket

• remove paraswap related logic
• remove not using files, e.g. https://github.com/SwingbyProtocol/skybridge-contract/blob/skypools-v2/contracts/Migrations.sol
• remove the old solidity compiler https://github.com/SwingbyProtocol/skybridge-contract/blob/skypools-v2/hardhat.config.ts#L40
• start integrate inch contracts