Skip to content

Removed custom keyboard navigation in package lists #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

Removed custom keyboard navigation in package lists #3896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions FrontEnd/main.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 0 additions & 13 deletions FrontEnd/scripts/dom_helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,3 @@ HTMLElement.prototype.findParentMatching = function (matches) {
} while ((element = element.parentElement))
return null
}

HTMLDocument.prototype.blurFocusedInputElement = function () {
const activeElement = this.activeElement
if (activeElement.nodeName.toLowerCase() === 'input') activeElement.blur()
}

Window.prototype.scrollToTop = function () {
window.scrollTo(0, 0)
}

Window.prototype.scrollToBottom = function () {
window.scrollTo(0, this.document.body.scrollHeight)
}
20 changes: 0 additions & 20 deletions FrontEnd/scripts/keycodes.js
View file
Open in desktop

This file was deleted.

147 changes: 0 additions & 147 deletions FrontEnd/scripts/package_list_navigation.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions FrontEnd/styles/colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@

--package-list-border: var(--very-light-grey);
--package-list-background: var(--very-very-light-grey);
--package-list-selectedbackground: var(--very-light-blue);

--error-background: var(--light-red);
--error-text: var(--mid-red);
Expand Down Expand Up @@ -289,7 +288,6 @@

--package-list-border: var(--very-dark-grey);
--package-list-background: var(--very-very-dark-grey);
--package-list-selectedbackground: var(--dark-blue);

--error-background: var(--dark-red);
--success-background: var(--very-dark-green);
Expand Down
4 changes: 0 additions & 4 deletions FrontEnd/styles/package_list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@
}
}

&.selected {
background-color: var(--package-list-selectedbackground);
}

ul.metadata {
display: inline-flex;
gap: 10px;
Expand Down
3 changes: 0 additions & 3 deletions Sources/App/Views/Search/SearchShow+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,6 @@ extension SearchShow {
)),
.ul(
.id("package-list"),
// Let the JavaScript know that keyboard navigation on this package list should
// also include navigation into and out of the query field.
.data(named: "focus-query-field", value: String(true)),
.group(
model.packageResults.map { .packageListItem(linkUrl: $0.packageURL, packageName: $0.packageName ?? $0.repositoryName, summary: $0.summary, matchingKeywords: model.matchingKeywords(packageKeywords: $0.keywords), repositoryOwner: $0.repositoryOwner, repositoryName: $0.repositoryName, stars: $0.stars, lastActivityAt: $0.lastActivityAt, hasDocs: $0.hasDocs) }
)
Expand Down
2 changes: 1 addition & 1 deletion Tests/AppTests/__Snapshots__/WebpageSnapshotTests/SearchShow_document.1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ <h1>
<div class="two-column mobile-reversed">
<section class="package-results">
<h4>Matching packages</h4>
<ul id="package-list" data-focus-query-field="true">
<ul id="package-list">
<li>
<a href="https://example.com/package/one">
<h4>Package One</h4>
Expand Down
2 changes: 1 addition & 1 deletion Tests/AppTests/__Snapshots__/WebpageSnapshotTests/SearchShow_document_withFilters.1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ <h4>Matching packages where&hellip;</h4>
<span class="filter-value">mit</span>
</li>
</ul>
<ul id="package-list" data-focus-query-field="true">
<ul id="package-list">
<li>
<a href="https://example.com/package/one">
<h4>Package One</h4>
Expand Down
2 changes: 1 addition & 1 deletion Tests/AppTests/__Snapshots__/WebpageSnapshotTests/SearchShow_document_withXSSAttempt.1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ <h1>
<section class="package-results">
<h4>Matching packages</h4>
<p>No packages found.</p>
<ul id="package-list" data-focus-query-field="true"></ul>
<ul id="package-list"></ul>
<ul class="pagination">
<li class="previous">
<a href="/search?query=&apos;&gt;&quot;&gt;&lt;/script&gt;&lt;svg/onload=confirm(&apos;XSS&apos;)&gt;&page=2">Previous Page</a>
Expand Down
Loading