Skip to content

Conversation

RemieJanssen
Copy link
Contributor

No description provided.

Copy link
Owner

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the well done translation! I reviewed the changes using a translator and they all seem pretty reasonable. I made some tiny changes here and there, see the comments in the review, and let me know if I made something wrong. The unresolved comments are those on which I am not completely sure. Thanks again!

Comment on lines 8 to 9
- pause|halt|stop|hold (the? song|media|track|music|audio|video|movie|stream|film)?
- put the? song|media|track|music|audio|video|movie|stream|film on hold
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably leftover:

Suggested change
- pause|halt|stop|hold (the? song|media|track|music|audio|video|movie|stream|film)?
- put the? song|media|track|music|audio|video|movie|stream|film on hold

Comment on lines +1 to +3
dial:
- bel naar? .who. op?
- .who. bellen
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there no other ways to say "Call .who."?

cancel:
- stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.)
- zet (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af|stil|uit?
- silence|(shut|turn off)|quiet|mute the? (.name.? time<r|rs?>|bell|alert|sound|ringtone)|(time<r|rs?>|bell|alert|sound|ringtone called|named|(with the name) .name.)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this also likely remained here by accident)

Comment on lines 1 to 13
set:
- timer|alarm (voor|over)? .duration.
- herinner me over .duration.
- zet|maak|start|begin een? timer|alarm (voor|van|over)? .duration. (genaamd|(de naam)|onder .name.)?

cancel:
- stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.)
- zet (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af|stil|uit?
- silence|(shut|turn off)|quiet|mute the? (.name.? time<r|rs?>|bell|alert|sound|ringtone)|(time<r|rs?>|bell|alert|sound|ringtone called|named|(with the name) .name.)

query:
- (hoe lang)|(hoeveel tijd|seconden|minuten|uren) (zijn er)? nog voor|op (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) (afgaat|afloopt)?
- wanneer loopt (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand "alarm" in Dutch means "alarm" in English (i.e. the thing that wakes you up in the morning). But this skill sets a timer, not an alarm, so I removed the word "alarm" from these sentences. Let me know if the meaning of "alarm" is actually different.

Suggested change
set:
- timer|alarm (voor|over)? .duration.
- herinner me over .duration.
- zet|maak|start|begin een? timer|alarm (voor|van|over)? .duration. (genaamd|(de naam)|onder .name.)?
cancel:
- stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.)
- zet (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af|stil|uit?
- silence|(shut|turn off)|quiet|mute the? (.name.? time<r|rs?>|bell|alert|sound|ringtone)|(time<r|rs?>|bell|alert|sound|ringtone called|named|(with the name) .name.)
query:
- (hoe lang)|(hoeveel tijd|seconden|minuten|uren) (zijn er)? nog voor|op (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) (afgaat|afloopt)?
- wanneer loopt (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af
set:
- timer (voor|over)? .duration.
- herinner me over .duration.
- zet|maak|start|begin een? timer (voor|van|over)? .duration. (genaamd|(de naam)|onder .name.)?
cancel:
- stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.)
- zet (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.) af|stil|uit?
query:
- (hoe lang)|(hoeveel tijd|seconden|minuten|uren) (zijn er)? nog voor|op (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.) (afgaat|afloopt)?
- wanneer loopt (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.) af

Copy link
Owner

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging for now, but feel free to reply to my feedback and submit more improvements! You can also test this APK, which includes your changes: https://github.com/Stypox/testing-apks/releases/download/24/app-debug.apk .

@Stypox Stypox merged commit 6fc4559 into Stypox:master Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants