-
-
Notifications
You must be signed in to change notification settings - Fork 112
Dutch language pack #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dutch language pack #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the well done translation! I reviewed the changes using a translator and they all seem pretty reasonable. I made some tiny changes here and there, see the comments in the review, and let me know if I made something wrong. The unresolved comments are those on which I am not completely sure. Thanks again!
app/src/main/sentences/nl/media.yml
Outdated
- pause|halt|stop|hold (the? song|media|track|music|audio|video|movie|stream|film)? | ||
- put the? song|media|track|music|audio|video|movie|stream|film on hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably leftover:
- pause|halt|stop|hold (the? song|media|track|music|audio|video|movie|stream|film)? | |
- put the? song|media|track|music|audio|video|movie|stream|film on hold |
dial: | ||
- bel naar? .who. op? | ||
- .who. bellen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there no other ways to say "Call .who."?
app/src/main/sentences/nl/timer.yml
Outdated
cancel: | ||
- stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) | ||
- zet (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af|stil|uit? | ||
- silence|(shut|turn off)|quiet|mute the? (.name.? time<r|rs?>|bell|alert|sound|ringtone)|(time<r|rs?>|bell|alert|sound|ringtone called|named|(with the name) .name.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this also likely remained here by accident)
app/src/main/sentences/nl/timer.yml
Outdated
set: | ||
- timer|alarm (voor|over)? .duration. | ||
- herinner me over .duration. | ||
- zet|maak|start|begin een? timer|alarm (voor|van|over)? .duration. (genaamd|(de naam)|onder .name.)? | ||
|
||
cancel: | ||
- stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) | ||
- zet (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af|stil|uit? | ||
- silence|(shut|turn off)|quiet|mute the? (.name.? time<r|rs?>|bell|alert|sound|ringtone)|(time<r|rs?>|bell|alert|sound|ringtone called|named|(with the name) .name.) | ||
|
||
query: | ||
- (hoe lang)|(hoeveel tijd|seconden|minuten|uren) (zijn er)? nog voor|op (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) (afgaat|afloopt)? | ||
- wanneer loopt (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand "alarm" in Dutch means "alarm" in English (i.e. the thing that wakes you up in the morning). But this skill sets a timer, not an alarm, so I removed the word "alarm" from these sentences. Let me know if the meaning of "alarm" is actually different.
set: | |
- timer|alarm (voor|over)? .duration. | |
- herinner me over .duration. | |
- zet|maak|start|begin een? timer|alarm (voor|van|over)? .duration. (genaamd|(de naam)|onder .name.)? | |
cancel: | |
- stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) | |
- zet (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af|stil|uit? | |
- silence|(shut|turn off)|quiet|mute the? (.name.? time<r|rs?>|bell|alert|sound|ringtone)|(time<r|rs?>|bell|alert|sound|ringtone called|named|(with the name) .name.) | |
query: | |
- (hoe lang)|(hoeveel tijd|seconden|minuten|uren) (zijn er)? nog voor|op (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) (afgaat|afloopt)? | |
- wanneer loopt (de|het)? (.name.? timer|alarm)|(timer|alarm genaamd|(met|onder de naam) .name.) af | |
set: | |
- timer (voor|over)? .duration. | |
- herinner me over .duration. | |
- zet|maak|start|begin een? timer (voor|van|over)? .duration. (genaamd|(de naam)|onder .name.)? | |
cancel: | |
- stop|"beëindig"|eindig|cancel|annuleer (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.) | |
- zet (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.) af|stil|uit? | |
query: | |
- (hoe lang)|(hoeveel tijd|seconden|minuten|uren) (zijn er)? nog voor|op (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.) (afgaat|afloopt)? | |
- wanneer loopt (de|het)? (.name.? timer)|(timer genaamd|(met|onder de naam) .name.) af |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm merging for now, but feel free to reply to my feedback and submit more improvements! You can also test this APK, which includes your changes: https://github.com/Stypox/testing-apks/releases/download/24/app-debug.apk .
No description provided.