Add setting for accepting longer user silences #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than always giving up as soon as Vosk indicates a single period of silence, allow the user to configure Dicio to accept up to seven consecutive periods of silence before it gives up.
Stypox
approved these changes
Jun 29, 2025
| @Composable | ||
| fun sttSilenceDuration() = IntSetting( | ||
| title = stringResource(R.string.pref_stt_silence_duration_title), | ||
| icon = Icons.AutoMirrored.Filled.Send, |
There was a problem hiding this comment.
I'd use a different icon here, like hourglass_empty
| UNRECOGNIZED, | ||
| INPUT_DEVICE_UNSET, | ||
| INPUT_DEVICE_VOSK -> VoskInputDevice(appContext, okHttpClient, localeManager) | ||
| INPUT_DEVICE_VOSK -> VoskInputDevice(appContext, okHttpClient, localeManager, settings) |
There was a problem hiding this comment.
If the user changes the settings after this has been built, the old settings instance will remain. It's probably better to maintain the previous code for the rest of the class and instead pass dataStore here.
| ) { | ||
| _state.value = Listening(speechService, eventListener) | ||
| speechService.startListening(VoskListener(this, eventListener, speechService)) | ||
| speechService.startListening(VoskListener(this, eventListener, settings.sttSilenceDuration, speechService)) |
There was a problem hiding this comment.
Is there a way to set settings.sttSilenceDuration to something like 2 by default (i.e. when the setting has never been changed by the user yet)?
Stypox
requested changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than always giving up as soon as Vosk indicates a single period of silence, allow the user to configure Dicio to accept up to seven consecutive periods of silence before it gives up.
I've been test driving a checklist skill that reads a list of steps and waits for me to confirm each one, and sometimes I'm not ready to respond immediately to Dicio. By extending the length of time that Vosk listens for speech, I'm able to make this skill more useful. The same option may be useful for other more "interactive" skills, so I'm contributing it as a separate PR before I'm ready to contribute back the checklist skill itself.