This repository was archived by the owner on Jun 5, 2023. It is now read-only.
Added EventHandler for UriChanging #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 2, 2020 14:37
Update testassets/HelloWorldApp/wwwroot/index.html Co-Authored-By: Steve Sanderson <[email protected]> Update src/WebWindow.Native/WebWindow.Mac.mm Co-Authored-By: Steve Sanderson <[email protected]> Update src/WebWindow.Native/WebWindow.Mac.mm Co-Authored-By: Steve Sanderson <[email protected]> Update src/WebWindow.Native/WebWindow.Mac.NavigationDelegate.mm Co-Authored-By: Steve Sanderson <[email protected]> Fixes for formatting typo in mac nav delegate mac callback changes More changes to mac Learning Objective-C as we go! More string manip issues syntax More mac fun UTF not Utf mac stuff Mac More mac mac more mac Added EventHandler for UriChanging Deleted .idea
malscent
commented
Jan 7, 2020
| PWSTR uri; | ||
| args->get_Uri(&uri); | ||
| _uriChangeCallback(uri); | ||
| CoTaskMemFree(uri); |
Author
There was a problem hiding this comment.
This CoTaskMemFree comes from https://docs.microsoft.com/en-us/microsoft-edge/hosting/webview2/gettingstarted#step-4---navigation-events
Direction needed on whether it should be removed or not.
Contributor
There was a problem hiding this comment.
How about using wil::unique_cotaskmem_string? It is just like unique_ptr and CoTaskMemFree will be called automatically.
Author
|
Any update on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening after fixing all of Steve's suggestions. I re-based and force pushed, which would not allow me to push to the previous PR.
For Reference.
#44