fix: handle disposed socket on close attempt #1591
Open
+32
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #524.
Some investigation
Originally I had the following stacktrace for ArchiSteamFarm:
ConnectedWebSocket
is a private property and there is no mention of it in SteamKit codebase whatsoever, so there is definitely some method that got inlined and its stackframe was omitted.ClientWebSocket
accesses that property in 7 methods:SendAsync
(+2 overloads),ReceiveAsync
(+1 overload),CloseAsync
,CloseOutputAsync
.WebSocketContext
calls these methods in these cases:SendAsync
is called fromWebSocketContext.SendAsync
<-WebSocketConnection.Send
, which doesn't match our stacktrace,ReceiveAsync
is called fromReadMessageAsync
, but theObjectDisposedException
is explicitly handled there,CloseAsync
seems to be the only suitable candidate.