Skip to content

Critical Security Exploit Fix and Tick 1.26 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Critical Security Exploit Fix and Tick 1.26 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified Build/SignCommands.dll
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion SignCommands/scMain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace SignCommands {
//TODO: Add infinite signs support & Global cooldowns
[ApiVersion(1, 22)]
[ApiVersion(1, 26)]
public class SignCommands : TerrariaPlugin {
public override string Name {
get { return "Sign Commands"; }
Expand Down
6 changes: 1 addition & 5 deletions SignCommands/scUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@ public static class ScUtils
/// <returns></returns>
public static bool CanCreate(TSPlayer player, ScSign sign)
{
if (sign.commands.Count == 0) return true;

var fails = sign.commands.Count(cmd => !cmd.Value.CanRun(player));

return fails != sign.commands.Values.Count;
return sign.commands.All(cmd => cmd.Value.CanRun(player));
}

public static bool CanEdit(TSPlayer player, ScSign sign)
Expand Down