Changed links for not accessible pages #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andren
force-pushed
the
dev/andren/external-confluence-link-workaround
branch
from
bd17588 to
e7d6fa4
Compare
andren
force-pushed
the
dev/andren/external-confluence-link-workaround
branch
from
e7d6fa4 to
7834e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #77
Before
See issue above
After
Page 4* is from confluence endpoint A, and page 2* is from confluence endpoint B. Page 2* is now being skipped due to not having access, instead of halting the export process.
If the exporter detects a link to an external Confluence endpoint, it could try to use the existing credentials to authenticate. If not successful, it could prompt for additional credentials to successfully export the page, or it could simply skip it.
I think the above approach would require a deeper redesign (how would we start the auth-flow mid-export?), so I took the simpler approach of skipping that external page.