-
-
Notifications
You must be signed in to change notification settings - Fork 104
Enable macOS traffic light controls in main window #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enable macOS traffic light controls in main window #591
Conversation
The code is good and minimalist and with no alternatives made, I guess it is better than nothing. Plus nice to have someone from mac community test how The question is though, does it have any impact on the access to title menu bar? I believe macs render these in top panel, although I have rather little experience with doing anything on macs so I could've been mistaken. I'm honestly eager to go with CSD on all platforms, but that would mean switching from menu bar to something else. |
Also, I might add it as a mac-only setting (to toggle between CSD/non-CSD, in the future I'll move to platform-independent setting once I'll work on CSD), the current infrastructure, while being convoluted, is still prepared well for adding this kind of change and should be a few lines away to add it. |
While you're looking into mac-only settings, I just wanted to mention that the “Hide menu bar with Alt” option doesn’t really have any effect on macOS since the menu bar is always located at the top of the screen and can’t be toggled that way. It might make sense to hide or disable that option on macOS to avoid confusion. |
Can-do, although if it's gonna be a non-mac-only, I feel like it's gonna introduce funny code… Since, in reality, it might use 2 different config entries and need from me to check both. At least if I won't do any code touches to it. Yeah, config infra in WebCord ain't great, I'm far from being happy how I did things within it. I saw some screens posted online of M$ engineer describing adding stuff to control panel as a hell of the work, and WebCord's barely better at it. I'm nowadays more knowledgeable, and WebCord by itself gave me a brief idea what shouldn't I do in the future to end with great software engineering, or at least great enough adding features won't take me decades while keeping most of my coding principles intact (yes, I still hate adding non-dev deps to my packages, and either prefer standard way of things or doing my own packages; |
616a66b
to
b53b672
Compare
Also, could you also show how traffic lights look on login screen, and behave on smaller window widths? It might be reasonable to try implement CSD slightly differently for the login page, given Discord doesn't contain any title bar in their design here… I mean, there might be no |
b53b672
to
f531750
Compare
This PR enables native macOS traffic light controls (close/minimize/maximize) in the main Electron window. This improves usability and consistency with native macOS apps.
Tested on macOS 15.3.1 (Apple Silicon).
Before:
After: