Skip to content

Conversation

huskeee
Copy link
Contributor

@huskeee huskeee commented Oct 13, 2025

If you're adding a new endpoint make sure that

Copy link
Member

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @huskeee

Thanks for the update of your endpoint! Just one small thing: Your new endpoint does not set a CORS header, which means it will not be usable by JavaScript-based clients. Fixing this is as simple as adding a Access-Control-Allow-Origin: * HTTP header to your response.

LGTM otherwise 🚀

Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have access-control-allow-origin: * now:

curl -i https://www.hackerspace.gr/spacestate.php
HTTP/2 200
server: nginx/1.29.1
date: Sun, 19 Oct 2025 14:16:58 GMT
content-type: application/json
x-powered-by: PHP/8.4.13
access-control-allow-origin: *

@rnestler rnestler merged commit 163c863 into SpaceApi:master Oct 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants