Create rule S8219 #5782
Open
Create rule S8219 #5782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teemu-rytilahti-sonarsource
requested changes
Oct 27, 2025
rules/S8219/secrets/metadata.json
Outdated
| @@ -0,0 +1,56 @@ | |||
| { | |||
| "title": "Azure DevOps app secret should not be disclosed", | |||
There was a problem hiding this comment.
Suggested change
| "title": "Azure DevOps app secret should not be disclosed", | |
| "title": "Azure DevOps app secrets should not be disclosed", |
For consistency with other secret rules.
rules/S8219/secrets/rule.adoc
Outdated
Comment on lines
124
to
125
| username = redacted # Compliant | ||
| # password = # Store it with keyring module |
There was a problem hiding this comment.
Suggested change
| username = redacted # Compliant | |
| # password = # Store it with keyring module | |
| username = redacted | |
| # password = # Compliant (password is stored in the keyring module) |
The compliant marker should be on the line that is compliant, would this work?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: