Skip to content

Conversation

surilindur
Copy link
Contributor

This is a small PR to use the built-in cache from the Node setup action, like in Comunica.

I will also see what happens when running the CI on MacOS and Windows, if that fails, I will drop it from the PR.

@surilindur surilindur force-pushed the chore/update-ci-workflow branch from f156086 to 4c4b1e1 Compare April 17, 2025 14:36
@surilindur
Copy link
Contributor Author

So it is possible to make the tests pass on Windows, by swapping all path stuff to use join from node:path but the CI becomes super slow. I think that is not a good idea for now, so I dropped it. 😅

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14518203491

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11346853095: 0.0%
Covered Lines: 112
Relevant Lines: 112

💛 - Coveralls

@rubensworks rubensworks merged commit 018a682 into SolidBench:master Apr 18, 2025
5 checks passed
@surilindur surilindur deleted the chore/update-ci-workflow branch April 18, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants