chore(DATAGO-115917): migrate enterprise reusable components #469
Conversation
WhiteSource Policy Violation Summary✅︎ No Blocking Whitesource Policy Violations found in solaceai/solace-agent-mesh-ui-pr-469! |
WhiteSource Policy Violation Summary✅︎ No Blocking Whitesource Policy Violations found in solaceai/solace-agent-mesh-pr-469! |
| import { Dialog, DialogContent, DialogDescription, DialogHeader, DialogTitle } from "@/lib/components/ui/dialog"; | ||
| import type { ButtonVariant } from "@/lib/types/ui"; | ||
|
|
||
| interface ConfirmationDialogProps { |
There was a problem hiding this comment.
For the moment, let's just move these three:
- ConfirmationDialog
- ErrorDialog
- LoadingBlocker
Then, in a related task, do an audit of the community code and use these components where applicable.
| onClose: () => void; | ||
| } | ||
|
|
||
| export const ErrorDialog: React.FC<ErrorDialogProps> = ({ title, error, errorDetails, onClose }) => { |
There was a problem hiding this comment.
Ditto for this component, feel free to improve.
There was a problem hiding this comment.
i didn't use a dialog trigger and left it open by default because i assume you wouldn't click into an error dialog
| confirmVariant?: ButtonVariant; | ||
| } | ||
|
|
||
| export const ConfirmationDialog: React.FC<ConfirmationDialogProps> = ({ title, message, onClose, onConfirm, confirmVariant = "default" }) => { |
There was a problem hiding this comment.
Feel free to improve this implementation!
- Take in optional
DialogTrigger - Use
DialogFooterandDialogClose
g-raman
changed the title
g-raman
force-pushed
the
raman/ai-115916/migrate-enterprise-reusable-components
branch
from
e7d72fa to
b282f6c
Compare
lgh-solace
left a comment
lgh-solace
left a comment
There was a problem hiding this comment.
Thanks! Please don't merge until after GA. 🙏
|
g-raman
deleted the
raman/ai-115916/migrate-enterprise-reusable-components
branch
No description provided.