Optimize for alternate storage backends #329
Open
+19
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the digital agency I work for we use Amazon's S3 for our image storage in production. We found your optimization post-processor and it worked well in development. However, when we went live we noticed the images were no longer being optimised.
The Django package we use is called django-storages: http://django-storages.readthedocs.org/en/latest/index.html
After digging into the
post_processor.pyI found thatthumbnail.pathis not set for cloud-based storage providers and raises aNotImplementedError. In this case I detect the file-type from theurlattribute and save the file referenced by thenameattribute.I confirm this is working with S3 but it should be generic enough to work with most other storage backends.