feat: add common cache service #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a common cache service at the server level to enable centralized cache configuration across all clients. The cache service can be disabled for hosted installations via the CACHE_ENABLED environment variable and supports configurable TTL through CACHE_TTL.
Key changes:
- Created a new
CacheServiceclass that wrapsNodeCachewith environment-based configuration - Updated the
Clientinterface to accept an optional cache parameter in theconfiguremethod - Migrated Bugsnag client from managing its own cache instance to using the shared cache service
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/common/cache.ts | New cache service implementation with environment-based configuration |
| src/common/types.ts | Updated Client interface to accept optional cache parameter |
| src/common/server.ts | Added cache service instantiation and accessor method |
| src/common/client-registry.ts | Updated to pass cache service to client configure methods |
| src/bugsnag/client.ts | Refactored to use shared cache service instead of local instance |
| src/tests/unit/bugsnag/client.test.ts | Updated tests to pass cache parameter and verify cache integration |
| src/zephyr/client.ts | Added cache parameter to configure signature |
| src/reflect/client.ts | Added cache parameter to configure signature |
| src/qmetry/client.ts | Added cache parameter to configure signature |
| src/pactflow/client.ts | Added cache parameter to configure signature and reformatted error messages |
| src/api-hub/client.ts | Added cache parameter to configure signature |
| src/common/transport-http.ts | Fixed comment describing POST message handling |
| src/index.ts | Removed empty line |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
src/common/client-registry.ts
Outdated
| } | ||
| } | ||
| if (await entry.configure(server, config)) { | ||
| if (await entry.configure(server, config, server.getCache())) { |
There was a problem hiding this comment.
Given it's in the server, shall we just let clients get the cache from there rather than pass it explicitly?
There was a problem hiding this comment.
ah yeh that makes sense
tomlongridge
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds common cache service at the top level, allowing it to be configured for the whole server and used by all clients.
Design
In order to allow configuring cache service for the whole mcp server. For a hosted install this will be disabled.
Changeset
Moving cache from bugsnag client to the server level
Testing
Makes no changes to client functionality