Skip to content

Conversation

@sazap10
Copy link
Contributor

@sazap10 sazap10 commented Sep 18, 2025

Goal

Design

Changeset

Testing

@github-actions
Copy link
Contributor

🎯 Coverage Target Met!

📈 Coverage Metrics

Metric Coverage Target Status
Lines 81.0% 80%
Functions 85.2% 80%
Branches 87.2% 80%
Statements 81.0% 80%

📊 Test Statistics

  • Total Lines: 2,470 / 3,051
  • Total Functions: 121 / 142
  • Total Branches: 414 / 475

🔍 Files Needing Coverage

File Coverage
src/bugsnag/utils/example-tool.ts 0.0%
src/bugsnag/utils/index.ts 0.0%
src/pactflow/client.ts 55.8%
src/pactflow/client/utils.ts 66.2%
src/bugsnag/shared-services.ts 69.3%

📝 Report generated on Node.js 22 • View workflow • Coverage by Vitest + v8

@github-actions
Copy link
Contributor

🎯 Coverage Target Met!

📈 Coverage Metrics

Metric Coverage Target Status
Lines 81.3% 80%
Functions 85.2% 80%
Branches 87.9% 80%
Statements 81.3% 80%

📊 Test Statistics

  • Total Lines: 2,459 / 3,024
  • Total Functions: 121 / 142
  • Total Branches: 414 / 471

🔍 Files Needing Coverage

File Coverage
src/bugsnag/utils/example-tool.ts 0.0%
src/bugsnag/utils/index.ts 0.0%
src/pactflow/client.ts 55.8%
src/pactflow/client/utils.ts 66.2%
src/bugsnag/shared-services.ts 69.3%

📝 Report generated on Node.js 22 • View workflow • Coverage by Vitest + v8

@sazap10 sazap10 marked this pull request as ready for review September 19, 2025 09:16
@sazap10 sazap10 requested a review from a team as a code owner September 19, 2025 09:16
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we want to keep these or not

direction: z.enum(["asc", "desc"]),

// URL parameters
nextUrl: z.string().url(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nextUrl: z.string().url(),
nextUrl: z.string(),

Next URL is passed as only the path without the hostname. Using Zod's url() will cause the call to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants